Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdevcan be null

[Sergei Shtylyov]

Hello.

On 08-03-2013 16:53, oskar.andero@xxxxxxxxxxxxxx wrote:

> From: Truls Bengtsson <truls.bengtsson@xxxxxxxxxxxxxx>

> The udc_irq service runs the isr_tr_complete_handler which in turn
> "nukes" the endpoints, including a call to rndis_response_complete,
> if appropriate. If the rndis_msg_parser fails here, an error will
> be printed using a dev_err call (through the ERROR() macro).

> However, if the usb cable was just disconnected the device (cdev)
> might not be available and will be null. Since the dev_err macro will
> dereference the cdev pointer we get a null pointer exception.

> Reviewed-by: Radovan Lekanovic <radovan.lekanovic@xxxxxxxxxxxxxx>
> Signed-off-by: Truls Bengtsson <truls.bengtsson@xxxxxxxxxxxxxx>
> Signed-off-by: Oskar Andero <oskar.andero@xxxxxxxxxxxxxx>
> ---
>   drivers/usb/gadget/f_rndis.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)

> diff --git a/drivers/usb/gadget/f_rndis.c b/drivers/usb/gadget/f_rndis.c
> index 71beeb8..41b5ebd 100644
> --- a/drivers/usb/gadget/f_rndis.c
> +++ b/drivers/usb/gadget/f_rndis.c
> @@ -6,6 +6,7 @@
>    * Copyright (C) 2008 Nokia Corporation
>    * Copyright (C) 2009 Samsung Electronics
>    *                    Author: Michal Nazarewicz (mina86@xxxxxxxxxx)
> + * Copyright (C) 2013 Sony Mobile Communications AB.

   Your change seems too insignificant to add a copyright.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/