Re: [PATCH 2/3 V2] intel_idle: Removing the redundant calculatingfor dev->state_count

From: Daniel Lezcano
Date: Mon Mar 11 2013 - 05:09:17 EST


On 03/11/2013 11:44 AM, Chuansheng Liu wrote:
>
> In function intel_idle_cpu_init() and intel_idle_cpuidle_driver_init(),
> they are having the same for(;;) loop to count the ->state_count.
>
> Although intel_idle_cpu_init() can be called at runtime CPU HOTPLUG case,
> but max_cstate can not be changed at runtime.
>
> So the dev->state_count should be == drv->state_count, in the function
> cpuidle_register_device() has done the initialization.
>
> Here we can clean up these pieces of code.
>
> Signed-off-by: liu chuansheng <chuansheng.liu@xxxxxxxxx>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>




--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/