Re: [PATCH v2 01/11] staging: Initial commit of TDM core

From: Greg Kroah-Hartman
Date: Mon Mar 11 2013 - 13:17:33 EST


On Fri, Mar 01, 2013 at 01:50:37PM +0300, Michail Kurachkin wrote:
> From: Michail Kurochkin <michail.kurachkin@xxxxxxxxxxx>
>
> Signed-off-by: Michail Kurochkin <michail.kurachkin@xxxxxxxxxxx>
> ---
> drivers/staging/Kconfig | 4 +
> drivers/staging/Makefile | 4 +-
> drivers/staging/tdm/Kconfig | 38 ++
> drivers/staging/tdm/Makefile | 19 +
> drivers/staging/tdm/tdm.h | 292 ++++++++++++++
> drivers/staging/tdm/tdm_core.c | 826 ++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 1182 insertions(+), 1 deletions(-)
> create mode 100644 drivers/staging/tdm/Kconfig
> create mode 100644 drivers/staging/tdm/Makefile
> create mode 100644 drivers/staging/tdm/tdm.h
> create mode 100644 drivers/staging/tdm/tdm_core.c
>
> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index 329bdb4..9bba991 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -26,6 +26,10 @@ if STAGING
>
> source "drivers/staging/et131x/Kconfig"
>
> +source "drivers/staging/si3226x/Kconfig"
> +
> +source "drivers/staging/tdm/Kconfig"

You just broke the build with this patch :(

Please, EVERY patch has to be buildable at every step of the way. I
can't take patches that break the build, especially ones that do so in
such obvious ways.

Please resend this whole series, fixing this problem, and changing the
Subject: lines like I asked for last time as well.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/