Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

From: Russell King - ARM Linux
Date: Tue Mar 12 2013 - 12:02:32 EST


On Tue, Mar 12, 2013 at 04:54:33PM +0100, Uwe Kleine-König wrote:
> +#include <asm/irq.h>
> +#include <asm/io.h>

linux/io.h

> + unsigned int irqs, i, irq_base;
> +
> + irq_base = irq_alloc_descs(-1, 16, irqs - 16, numa_node_id());
> + if (IS_ERR_VALUE(irq_base)) {

Erm... irq_alloc_descs() returns a negative number on error.

if ((int)irq_base < 0)

or make irq_base an int, and use:

if (irq_base < 0)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/