Re: [ 33/40] rtc: rtc-mv: Add support for clk to avoid lockups

From: Greg Kroah-Hartman
Date: Tue Mar 12 2013 - 19:15:37 EST


On Tue, Mar 12, 2013 at 07:08:43PM -0400, Jason Cooper wrote:
> Greg,
>
> On Tue, Mar 12, 2013 at 03:43:54PM -0700, Greg Kroah-Hartman wrote:
> > 3.4-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Andrew Lunn <andrew@xxxxxxx>
> >
> > commit 89c58c198b252f2bc20657fdd72a2aea788c435c upstream.
> >
> > The Marvell RTC on Kirkwood makes use of the runit clock. Ensure the
> > driver clk_prepare_enable() this clock, otherwise there is a danger
> > the SoC will lockup when accessing RTC registers with the clock
> > disabled.
> >
> > Reported-by: Simon Baatz <gmbnomis@xxxxxxxxx>
> > Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
> > Tested-by: Simon Baatz <gmbnomis@xxxxxxxxx>
> > Signed-off-by: Jason Cooper <jason@xxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >
> > ---
> > arch/arm/boot/dts/kirkwood.dtsi | 1 +
> > drivers/rtc/rtc-mv.c | 28 ++++++++++++++++++++++++----
> > 2 files changed, 25 insertions(+), 4 deletions(-)
>
> Please drop from 3.4-stable. devm_clk_get() wasn't available.

Now dropped.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/