Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

From: Sedat Dilek
Date: Wed Mar 13 2013 - 11:53:15 EST


On Wed, Mar 13, 2013 at 4:26 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> On Wed, Mar 13, 2013 at 4:18 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>>> Looks like this is missing (or intended?):
>>>
>>> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
>>> index 482c26f..f23ebfc 100644
>>> --- a/fs/overlayfs/super.c
>>> +++ b/fs/overlayfs/super.c
>>> @@ -684,3 +684,6 @@ static void __exit ovl_exit(void)
>>>
>>> module_init(ovl_init);
>>> module_exit(ovl_exit);
>>> +MODULE_DESCRIPTION("overlayfs v17: provides overlay-filesystem functionality");
>>> +MODULE_AUTHOR("Miklos Szeredi <miklos@xxxxxxxxxx>");
>>> +MODULE_LICENSE("GPL");
>>
>> No, it *is* already in there.
>>
>
> Where is it?
>
> Last lines in [1] are:
>
> 685 module_init(ovl_init);
> 686 module_exit(ovl_exit);
>

OK, I looked at SquashFS which is not converted to use MODULE_ALIAS_FS.

Hehe, with my patch that looks now funny :-).

$ sudo modinfo overlayfs
filename:
/lib/modules/3.9.0-rc2-next20130313-4-iniza-small/kernel/fs/overlayfs/overlayfs.ko
license: GPL
author: Miklos Szeredi <miklos@xxxxxxxxxx>
description: overlayfs v17, provides overlay-filesystem functionality
alias: fs-overlayfs
license: GPL
description: Overlay filesystem
author: Miklos Szeredi <miklos@xxxxxxxxxx>
srcversion: 4332BB91603829A85CCEA59
depends:
intree: Y
vermagic: 3.9.0-rc2-next20130313-4-iniza-small SMP mod_unload modversions


$ sudo modinfo squashfs
filename:
/lib/modules/3.9.0-rc2-next20130313-4-iniza-small/kernel/fs/squashfs/squashfs.ko
license: GPL
author: Phillip Lougher <phillip@xxxxxxxxxxxxxxx>
description: squashfs 4.0, a compressed read-only filesystem
alias: fs-squashfs
srcversion: 752DB671D8E8DFB606BFC88
depends:
intree: Y
vermagic: 3.9.0-rc2-next20130313-4-iniza-small SMP mod_unload modversions

- Sedat -

> - Sedat -
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/mszeredi/vfs.git/tree/fs/overlayfs/super.c?h=overlayfs.current
>
>> Thanks,
>> Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/