Re: [PATCH 1/2] usb: dwc3: exynos: Use of_platform API to createdwc3 core pdev

From: Felipe Balbi
Date: Thu Mar 14 2013 - 06:52:20 EST


Hi,

On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote:
> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device *pdev)
> {
> struct dwc3_exynos *exynos = platform_get_drvdata(pdev);
>
> - platform_device_unregister(exynos->dwc3);

don't you want to do what Kishon did here and have:

static int dwc3_exynos_remove_child(struct device *dev, void *unused)
{
struct platform_device *pdev = to_platform_device(dev);

platform_device_unregister(pdev);

return 0;
}

device_for_each_child(&pdev->dev, NULL, dwc3_exynos_remove_child);

???

--
balbi

Attachment: signature.asc
Description: Digital signature