RE: linux-next: build failure after merge of the final tree(staging tree related)

From: Paul Zimmerman
Date: Thu Mar 14 2013 - 16:23:58 EST


> From: Stephen Rothwell [mailto:sfr@xxxxxxxxxxxxxxxx]
> Sent: Tuesday, March 12, 2013 10:40 PM
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/staging/dwc2/hcd.c: In function '_dwc2_hcd_urb_enqueue':
> drivers/staging/dwc2/hcd.c:2387:3: error: implicit declaration of function 'bus_to_virt' [-Werror=implicit-function-declaration]
> drivers/staging/dwc2/hcd.c:2387:7: warning: assignment makes pointer from integer without a cast [enabled by default]
>
> Caused by commit 7359d482eb4d ("staging: HCD files for the DWC2 driver").
>
> From Documentation/bus-virt-phys-mapping.txt:
>
> "[ NOTE: The virt_to_bus() and bus_to_virt() functions have been
> superseded by the functionality provided by the PCI DMA interface
> (see Documentation/DMA-API-HOWTO.txt). They continue
> to be documented below for historical purposes, but new code
> must not use them. --davidm 00/12/12 ]"
>
> See also Documentation/DMA-API-HOWTO.txt.
>
> I have added this patch for today:
>
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date: Wed, 13 Mar 2013 16:35:50 +1100
> Subject: [PATCH] staging: the DWC2 driver uses bus_to_virt
>
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> ---
> drivers/staging/dwc2/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/dwc2/Kconfig b/drivers/staging/dwc2/Kconfig
> index 610418a..bc4cdfe 100644
> --- a/drivers/staging/dwc2/Kconfig
> +++ b/drivers/staging/dwc2/Kconfig
> @@ -1,6 +1,7 @@
> config USB_DWC2
> tristate "DesignWare USB2 DRD Core Support"
> depends on USB
> + depends on VIRT_TO_BUS
> select USB_OTG_UTILS
> help
> Say Y or M here if your system has a Dual Role HighSpeed
> --

Hi Greg,

Do you apply these sort of patches automatically, or do you need an ack from me?
In case you do:

Acked-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/