Re: [PATCH 25/50] staging: omap-thermal: rewriteomap_bandgap_mcelsius_to_adc on kernel coding style

From: Dan Carpenter
Date: Sat Mar 16 2013 - 04:33:24 EST

On Fri, Mar 15, 2013 at 09:00:13AM -0400, Eduardo Valentin wrote:
> Follow Documentation/CodingStyle while doing omap_bandgap_mcelsius_to_adc

I have the same response for all these bunny hop patches.

When you're reading the code and you see a goto then you assume that
it's there for a reason so it's misleading when it doesn't do
anything. It's simpler if the code is simple.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at