Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

From: Eduardo Valentin
Date: Sat Mar 16 2013 - 08:46:23 EST

Hello Dan,

On 16-03-2013 05:05, Dan Carpenter wrote:
I've reviewed this set.

I hate to make people redo whole patchset sets, and I hate
re-reviewing code. Obviously, I don't really like the bunny hop
patches and I'm trying to discourage that going forward. ;P But
I wouldn't say it's a "Redo the whole thing" kind of problem.

Could just resend patch 33 and 47? You should probably be able to
redo those without changing the rest.

I could of course change them if the comment is better clarified. As I mentioned as reply to one of your comments, those changes are following what is suggested in CodingStyle file.

I can of course send a diff on top of 33, to fix the introduce bug.

For 47, I'm not sure the comment is fully applicable.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at