Re: [PATCH 0/2] finx argv_split() vs sysctl race
From: Andi Kleen
Date: Sat Mar 16 2013 - 16:56:41 EST
> Perhaps rcu can be better, although a global rwsem looks simpler,
> I dunno.
It's a general problem with lots of sysctls.
> But argv_split() or its usage should be changed anyway, and GFP_KERNEL
> won't work under rcu_read_lock().
rcu strings has a helper function to copy the string for sleepy cases.
> To me 1/2 looks as a simplification anyway, but I won't argue if we
> decide to add rcu/locking and avoid this patch.
Ok I'll revisit. I think the problem last time was that the rcu strings
needed a kernel_text_address() function that worked on all
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/