On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote:Hello Dan,
On 16-03-2013 05:05, Dan Carpenter wrote:I've reviewed this set.
I hate to make people redo whole patchset sets, and I hate
re-reviewing code. Obviously, I don't really like the bunny hop
patches and I'm trying to discourage that going forward. ;P But
I wouldn't say it's a "Redo the whole thing" kind of problem.
Could just resend patch 33 and 47? You should probably be able to
redo those without changing the rest.
I could of course change them if the comment is better clarified. As
I mentioned as reply to one of your comments, those changes are
following what is suggested in CodingStyle file.
I can of course send a diff on top of 33, to fix the introduce bug.
For 47, I'm not sure the comment is fully applicable.
As I've taken all of these already (sorry Dan, I was fast and I didn't
review them as well as you did), you will have to just send incremental
patches on top of the whole series in order for me to be able to apply