Re: [PATCH 2/2] tracing: syscall_regfunc() should not skip kernelthreads
From: Oleg Nesterov
Date: Mon Mar 18 2013 - 12:29:10 EST
On 03/17, Steven Rostedt wrote:
> On Sun, 2013-03-17 at 20:04 +0100, Oleg Nesterov wrote:
> > > I'm really thinking the TIF_SYSCALL_TRACEPOINT flag is getting a bit
> > > ridiculous. We really should have a "swap syscall table when tracepoints
> > > enabled" that changes the syscall table that does exactly the same thing
> > > as the normal table but wraps the system call with the tracepoints.
> > But we also need to force the slow path in system_call...
> Why? If we remove the tracepoint from the slowpath and use a table swap,
> then we wouldn't need to use the slowpath at all.
Ah, indeed, you are right.
> > Anyway, do you agree with this change for now?
> Well, if it's solving a bug today sure. But we should really be looking
> at fixing what's there for the future.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/