Re: [PATCH 3/3] lib/kobject: WARN_ON corresponds to BUG_ON

[Xiao Guangrong]

On 03/19/2013 03:03 PM, Xiao Guangrong wrote:
> On 03/19/2013 02:47 PM, Dong Hao wrote:
>> From: Dong Hao <haodong@xxxxxxxxxxxxxxxxxx>
>>
>> WARN_ON corresponds to BUG_ON and also gets more info.
> 
> Change the log like this:
> like the comments said, double initialize a kobj is wrong
> but can be recoverd, using WARN_ON to warn the developer also
> it can get more info.
> 
> (Or you refine the code by yourself.)

s/code/comment

> 
>>
>> Signed-off-by: Dong Hao <haodong@xxxxxxxxxxxxxxxxxx>
>> ---
>>  lib/kobject.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/kobject.c b/lib/kobject.c
>> index ff9b3c3..f7d9f31 100644
>> --- a/lib/kobject.c
>> +++ b/lib/kobject.c
>> @@ -281,7 +281,7 @@ void kobject_init(struct kobject *kobj, struct kobj_type *ktype)
>>  		/* do not error out as sometimes we can recover */
>>  		printk(KERN_ERR "kobject (%p): tried to init an initialized "
>>  		       "object, something is seriously wrong.\n", kobj);
>> -		dump_stack();
>> +		WARN_ON(1);
>>  	}
>>
>>  	kobject_init_internal(kobj);
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/