Re: [PATCH 1/3] rbtree_test: use pr_info for module prefix in messages
From: Shuah Khan
Date: Tue Mar 19 2013 - 13:54:23 EST
On Tue, Mar 19, 2013 at 11:14 AM, Davidlohr Bueso
> On Tue, 2013-03-19 at 10:29 -0600, Shuah Khan wrote:
>> On Mon, Mar 18, 2013 at 5:20 PM, Davidlohr Bueso <davidlohr.bueso@xxxxxx> wrote:
>> > This provides nicer message output. Since it seems more appropriate
>> > for the nature of this module, also use KERN_INFO instead of other
>> > levels.
>> Why are you changing the ALERTs to INFO?
> Because of the nature of the messages. They don't justify having a
> KERN_ALERT level (requiring immediate attention), and it seems a lot
> more suitable to use INFO instead.
Hmm. I see interval_tree_test using the same alerts. It almost looks
like the start and end of a test are meant to be alerts. I am not
saying it shouldn't be changed, however looking for a stronger reason
than "it seems a lot more suitable to use INFO instead". Are there any
use-cases in which KERN_ALERTs cause problems?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/