Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up.
From: Stephen Warren
Date: Tue Mar 19 2013 - 16:10:34 EST
On 03/18/2013 06:29 AM, Venu Byravarasu wrote:
> Check return values from all GPIO APIs and handle errors accordingly.
> Remove clk_disable_unprepare which is no more needed.
The call to clk_disable_unprepare is incorrect in the current code. The
way you worded that, it sounds like it's no longer needed because of the
changes made in this patch. I would re-write that last sentence as:
Remove the call to clk_disable_unprepare(); this function does not
prepare or enable the clock, so the error path should not disable or
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/