Re: [PATCH 1/2] dma-debug: Fix locking bug in check_unmap

From: Shuah Khan
Date: Tue Mar 19 2013 - 16:29:17 EST


On Mon, 2013-03-18 at 15:12 -0700, Alexander Duyck wrote:
> In check_unmap it is possible to get into a dead-locked state if
> dma_mapping_error is called. The problem is that the bucket is locked in
> check_unmap, and locked again by debug_dma_mapping_error which is called by
> dma_mapping_error. To resolve that we must release the lock on the bucket
> before making the call to dma_mapping_error.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>

Looks good.

Reviewed-by: Shuah Khan
Tested-by Shuah Khan

Thanks for finding and fixing the problem.
-- Shuah


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/