RE: [PATCH 1/7] ARM: tegra: finalize USB EHCI and PHY bindings
From: Venu Byravarasu
Date: Wed Mar 20 2013 - 08:15:56 EST
> -----Original Message-----
> From: kishon [mailto:kishon@xxxxxx]
> Sent: Wednesday, March 20, 2013 4:49 PM
> To: Venu Byravarasu
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx;
> balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> swarren@xxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; devicetree-
> Subject: Re: [PATCH 1/7] ARM: tegra: finalize USB EHCI and PHY bindings
> On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
> > The existing Tegra USB bindings have a few issues:
> > 1) Many properties are documented as being part of the EHCI controller
> > node, yet they apply more to the PHY device. They should be moved.
> > 2) Some registers in PHY1 are shared with PHY3, and hence PHY3 needs a
> > reg entry to point at PHY1's register space. We can't assume the PHY1
> > driver is present, so the PHY3 driver will directly access those
> > registers.
> > 3) The list of clocks required by the PHY was missing some required
> > entries.
> > This patch fixes the binding definition to resolve these issues.
> > Signed-off-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx>
> > ---
> > .../bindings/usb/nvidia,tegra20-ehci.txt | 27 +++----------------
> > .../bindings/usb/nvidia,tegra20-usb-phy.txt | 27
> > 2 files changed, 29 insertions(+), 25 deletions(-)
> > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20-ehci.txt
> > index 34c9528..df09330 100644
> > --- a/Documentation/devicetree/bindings/usb/nvidia,tegra20-ehci.txt
> > +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra20-ehci.txt
> > @@ -6,27 +6,10 @@ Practice : Universal Serial Bus" with the following
> > and additions :
> > Required properties :
> > - - compatible : Should be "nvidia,tegra20-ehci" for USB controllers
> > - used in host mode.
> > - - phy_type : Should be one of "ulpi" or "utmi".
> > Optional properties:
> > - - dr_mode : dual role mode. Indicates the working mode for
> > index 6bdaba2..7ceccd3 100644
> > --- a/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt
> > +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt
> > @@ -4,8 +4,24 @@ The device node for Tegra SOC USB PHY:
> > Required properties :
> > + - phy_type : Should be one of "utmi", "ulpi" or "hsic".
> dt property names generally dont have "_".
Thanks Kishon, for your comments.
Is it mandatory or optional?
If it is mandatory, then I might have to change dr_mode as well along with phy_type.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/