Re: [PATCH] drivers/rtc/rtc-tegra.c: fix build warning

From: Jingoo Han
Date: Wed Mar 20 2013 - 22:16:26 EST


On Wed, 20 Mar 2013 05:30:25 -0700, Laxman Dewangan wrote:
>
> Fix the below build warning:
>
> drivers/rtc/rtc-tegra.c: In function 'tegra_rtc_probe':
> drivers/rtc/rtc-tegra.c:353:33: warning: passing argument 1 of
> 'devm_rtc_device_register' from incompatible pointer type [enabled by default]
> include/linux/rtc.h:136:27: note: expected 'struct device *' but argument is of
> type 'const char *'
> drivers/rtc/rtc-tegra.c:353:33: warning: passing argument 2 of
> 'devm_rtc_device_register' from incompatible pointer type [enabled by default]
> include/linux/rtc.h:136:27: note: expected 'const char *' but argument is of
> type 'struct device *'
> This warning was introduced with patch
> commit 8a96d445e921b0d881421767fb6f7c5b6fb91b3a
> drivers/rtc/rtc-tegra.c: use managed rtc_device_register()
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>

It looks good.

Reviewed-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Best regards,
Jingoo Han

> ---
> drivers/rtc/rtc-tegra.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
> index 7cb3da0..a34315d 100644
> --- a/drivers/rtc/rtc-tegra.c
> +++ b/drivers/rtc/rtc-tegra.c
> @@ -349,8 +349,9 @@ static int __init tegra_rtc_probe(struct platform_device
> *pdev)
>
> device_init_wakeup(&pdev->dev, 1);
>
> - info->rtc_dev = devm_rtc_device_register(dev_name(&pdev->dev),
> - &pdev->dev, &tegra_rtc_ops, THIS_MODULE);
> + info->rtc_dev = devm_rtc_device_register(&pdev->dev,
> + dev_name(&pdev->dev), &tegra_rtc_ops,
> + THIS_MODULE);
> if (IS_ERR(info->rtc_dev)) {
> ret = PTR_ERR(info->rtc_dev);
> dev_err(&pdev->dev, "Unable to register device (err=%d).\n",
> --
> 1.7.1.1
N떑꿩ry鉉싕bXФ푤v^)頻{.n+돴{묎zX㎍썳變}옽Ơz&j:+v돣묎zZ++zf"h닱~넮녬i鎬zwⅱ?솳鈺&)刪f뷌^j푹ym끷@Aa뛴 0띠hi