Re: linux-next: build failure after merge of the tty tree

From: Stephen Rothwell
Date: Thu Mar 21 2013 - 00:20:24 EST


Hi Greg,

On Wed, 20 Mar 2013 14:12:11 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/caif/caif_serial.c: In function 'update_tty_status':
> drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct' has no member named 'warned'
>
> Caused by commit 6865ff222cca ("TTY: do not warn about setting speed via
> SPD_*").

I still have this error today so have still used the tty tree from
next-20130319.

> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
> drivers/usb/serial/quatech2.c:661:18: error: 'struct qt2_port_private' has no member named 'is_open'
> drivers/usb/serial/quatech2.c:705:15: error: 'struct qt2_port_private' has no member named 'is_open'
>
> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded
> is_open"). grep is your friend (or searching while editting the file).

As has been reported, this one is fixed by reverting commit 27b351c "USB:
quatech2: only write to the tty if the port is open".

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature