Re: [PATCH] KVM: allow host header to be included even for!CONFIG_KVM
From: Gleb Natapov
Date: Thu Mar 21 2013 - 03:37:33 EST
On Wed, Mar 20, 2013 at 06:58:41PM -0500, Scott Wood wrote:
> On 03/14/2013 07:13:46 PM, Kevin Hilman wrote:
> >The new context tracking subsystem unconditionally includes kvm_host.h
> >headers for the guest enter/exit macros. This causes a compile
> >failure when KVM is not enabled.
> >Fix by adding an IS_ENABLED(CONFIG_KVM) check to kvm_host so it can
> >be included/compiled even when KVM is not enabled.
> >Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> >Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxx>
> >Applies on v3.9-rc2
> > include/linux/kvm_host.h | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> This broke the PPC non-KVM build, which was relying on stub
> functions in kvm_ppc.h, which relies on "struct vcpu" in kvm_host.h.
> Why can't the entirety kvm_host.h be included regardless of
> CONFIG_KVM, just like most other feature-specific headers? Why
> can't the if/else just go around the functions that you want to stub
> out for non-KVM builds?
What compilation failure this patch fixes? I presume something ARM
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/