Re: [BUG] staging: android: ashmem: Deadlock during ashmem_mmap and ashmem_read
From: Robert Love
Date: Thu Mar 21 2013 - 10:18:46 EST
On Thu, Mar 21, 2013 at 10:06 AM, Bjorn Bringert <bringert@xxxxxxxxxx> wrote:
> I did implement ashmem_read, but I had no idea what I was doing. Calling the
> VFS read function seemed like an obvious way to do it, but it might be
> wrong. If that needs fixing, then the similar VFS call in ashmem_llseek
> probably needs fixing too.
You don't want to hold ashmem_mutex across the VFS calls. It is only
needed to protect the ashmem-internal structures.
FWIW is Android now using ashmem_read()? I left it out of the original
ashmem implementation on purpose.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/