Re: [PATCH 02/11] ARM: remove extra timer-sp control registerclearing
From: Russell King - ARM Linux
Date: Thu Mar 21 2013 - 16:13:15 EST
On Wed, Mar 20, 2013 at 05:54:02PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring@xxxxxxxxxxx>
> The timer-sp initialization code clears the control register before
> initializing the timers, so every platform doing this is redundant.
> For unused timers, we should not care what state they are in.
NAK. We do care what state they're in. What if they have their interrupt
enable bit set, and IRQ is shared with the clock event timer?
No, this patch is just wrong.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/