Re: [PATCH] memcg: fix memcg_cache_name() to use cgroup_name()
From: Glauber Costa
Date: Fri Mar 22 2013 - 04:34:19 EST
On 03/22/2013 12:17 PM, Li Zefan wrote:
>> GFP_TEMPORARY groups short lived allocations but the mem cache is not
>> > an ideal candidate of this type of allocations..
> I'm not sure I'm following you...
> char *memcg_cache_name()
> char *name = alloc();
> return name;
> name = memcg_cache_name();
> Isn't this a short lived allocation?
Thanks for identifying and fixing this.
Li is right. The cache name will live long, but this is because the
slab/slub caches will strdup it internally. So the actual memcg
allocation is short lived.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/