Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors
From: Rafael J. Wysocki
Date: Fri Mar 22 2013 - 07:47:54 EST
On Friday, March 22, 2013 07:50:54 AM Viresh Kumar wrote:
> On 22 March 2013 05:14, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> > On Wednesday, March 20, 2013 10:59:13 AM Viresh Kumar wrote:
> >> I have queued all patches i had for 3.10 here:
> >> http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/for-3.10
> > OK, applied these to linux-pm.git/bleeding-edge.
> > At the moment bleeding-edge and linux-next diverged slightly on cpufreq, but
> > I hope the bleeding-edge material won't cause build problems to occur, so I'll
> > be able to move it to linux-next shortly.
> There shouldn't be any build problems not because i have done all build testing
> properly BUT because my tree is under continuously surveillance by Fengguang's
> bot. And any problem with my branches is reported very early :)
> >> commit f02fca9a2478088c4f7dadf82d998ae007a56285
> >> Author: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> >> Date: Wed Mar 20 10:50:33 2013 +0530
> >> fixup! cpufreq: governor: Implement per policy instances of governors
> > I'd actually prefer you to post complete updated patches instead of these
> > fixups. They are real PITA for me and probably for everybody else trying
> > to follow the cpufreq development recently.
> Hmm... I always thought fixups are way easy to review (and i still
> believe that's
> true) as they just contain what got changed and so people don't have to review
> whole patch again.
They won't have to if you write in the preamble what the differences from
previous versions are.
> BUT people who are looking for complete patches to apply
> would be annoyed by this and hence i always show them path of my repo
> where they can find it.
The problem with this approach is that the complete patches never make it to
the mailing lists and people have problems with connecting commits to
previously posted patches.
Moreover, it is *much* more convenient to me to take patches from kernel.org
patchwork than from your repos, with all due respect.
> So, what i may do is, post fixups and then resend
> patches. So that reviewer knows what changed and others can have complete
> patches too.
Sure, that will work too.
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/