Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instancesof governors
From: Viresh Kumar
Date: Fri Mar 22 2013 - 07:51:25 EST
On Fri, Mar 22, 2013 at 5:25 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Friday, March 22, 2013 07:50:54 AM Viresh Kumar wrote:
>> Hmm... I always thought fixups are way easy to review (and i still
>> believe that's
>> true) as they just contain what got changed and so people don't have to review
>> whole patch again.
> They won't have to if you write in the preamble what the differences from
> previous versions are.
You didn't get me.. How will the reviewer check if author has done what he
is saying in preamble and he hasn't broken anything new?
>> BUT people who are looking for complete patches to apply
>> would be annoyed by this and hence i always show them path of my repo
>> where they can find it.
> The problem with this approach is that the complete patches never make it to
> the mailing lists and people have problems with connecting commits to
> previously posted patches.
> Moreover, it is *much* more convenient to me to take patches from kernel.org
> patchwork than from your repos, with all due respect.
I understand.. I push them to repo only when they are broken, otherwise not.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/