Re: [PATCH net-next 6/7] r8169: add a new chip for RTL8106E

From: Francois Romieu
Date: Mon Apr 01 2013 - 18:23:46 EST


Hayes Wang <hayeswang@xxxxxxxxxxx> :
[...]
> - move rtl_set_rx_tx_desc_registers to avoid the tx/rx are enabled
> before setting desc registers.

This is a wholesale change for the 810x family.

Please explain why issuing rtl_set_rx_tx_desc_registers before writing
ChipCmd is not enough and feed it through a standalone commit.

> Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>
> ---
> drivers/net/ethernet/realtek/r8169.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 8d41508..876e088 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -49,6 +49,7 @@
> #define FIRMWARE_8106E_1 "rtl_nic/rtl8106e-1.fw"
> #define FIRMWARE_8168G_2 "rtl_nic/rtl8168g-2.fw"
> #define FIRMWARE_8168G_3 "rtl_nic/rtl8168g-3.fw"
> +#define FIRMWARE_8106E_2 "rtl_nic/rtl8106e-2.fw"

I'd rather keep those sorted.

[...]
> @@ -824,6 +829,7 @@ MODULE_FIRMWARE(FIRMWARE_8411_1);
> MODULE_FIRMWARE(FIRMWARE_8106E_1);
> MODULE_FIRMWARE(FIRMWARE_8168G_2);
> MODULE_FIRMWARE(FIRMWARE_8168G_3);
> +MODULE_FIRMWARE(FIRMWARE_8106E_2);

Same thing as above.

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/