Re: [PATCH 20/23] perf: consolidate CONFIG_LIBELF checks in Makefile

[Paul Bolle]

On Mon, 2013-04-01 at 21:54 -0600, David Ahern wrote:
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
>[...]
> @@ -602,6 +590,16 @@ ifdef CONFIG_LIBELF
>      endif
>  
>  else
> +    ifdef CONFIG_DWARF
> +        $(error CONFIG_DWARF depends on LIBELF)
> +    endif
> +    ifdef CONFIG_DEMANGLE
> +        $(error CONFIG_DEMANGLE depends on LIBELF)
> +    endif
> +    ifdef CONFIG_LIBUNWIND
> +        $(error CONFIG_LIBUNWIND depends on LIBELF)
> +    endif
> +
>      EXTLIBS := $(filter-out -lelf,$(EXTLIBS))
>  
>      # Remove ELF/DWARF dependent codes

A quick scan of your series suggests you check here for dependencies
that are already enforced by the kconfig tools. Why is this needed?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/