Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

[Greg KH]

On Tue, Apr 02, 2013 at 04:00:42PM -0700, Greg KH wrote:
> I'm not even going to review the rest of this file, please fix that up
> first, before sending it out again.  And, when you do so, please cc: me.

It's like a train wreck, you just can't tear away your eyes...

You race with userspace in the creation of your sysfs files.  Your
device is announced to userspace and then, later on, you create the
sysfs files.  This means that tools like libudev never sees your files,
so the attributes aren't read properly by loads of userspace programs
that you want to have read them.

Please fix that before resending this as well.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/