Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

From: Alex Shi
Date: Tue Apr 02 2013 - 22:13:13 EST


On 04/03/2013 09:23 AM, Paul Turner wrote:
> Nack:
> Vincent is correct, rq->avg is supposed to be the average time that an
> rq is runnable; this includes (for example) SCHED_RT.
>
> It's intended to be more useful as a hint towards something like a
> power governor which wants to know how busy the CPU is in general.

Thanks PJT&Vincent. agree with your thought.
>
>> On the other side, periodic LB balance on combined the cfs/rt load, but
>> removed the RT utilisation in cpu_power.
>
> This I don't quite understand; these inputs are already time scaled (by decay).
>
> Stated alternatively, what you want is:
> "average load" / "available power", which is:
> (rq->cfs.runnable_load_avg + rq->cfs.blocked_load_avg) / (cpu power
> scaled for rt)

Right. understand,


--
Thanks Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/