Re: [PATCH 3/4] regulator: ab8500: Fix 'match_size' undeclared andmissing semicolon

From: Lee Jones
Date: Wed Apr 03 2013 - 04:22:31 EST


On Wed, 03 Apr 2013, Axel Lin wrote:

> Fix below build errors:
> CC drivers/regulator/ab8500.o
> drivers/regulator/ab8500.c: In function 'ab8500_regulator_probe':
> drivers/regulator/ab8500.c:3018:3: error: 'match_size' undeclared (first use in this function)
> drivers/regulator/ab8500.c:3018:3: note: each undeclared identifier is reported only once for each function it appears in
> drivers/regulator/ab8500.c:3019:2: error: expected ';' before '}' token
> drivers/regulator/ab8500.c:3036:2: error: expected ';' before '}' token
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
> drivers/regulator/ab8500.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
> index bdd17e6..73d84d8 100644
> --- a/drivers/regulator/ab8500.c
> +++ b/drivers/regulator/ab8500.c
> @@ -3007,7 +3007,7 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
> struct ab8500_regulator_info *regulator_info;
> int regulator_info_size;
> struct ab8500_reg_init *reg_init;
> - int reg_init_size;
> + int reg_init_size, match_size;
>
> if (is_ab9540(ab8500)) {
> regulator_info = ab9540_regulator_info;
> @@ -3015,7 +3015,7 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
> reg_init = ab9540_reg_init;
> reg_init_size = AB9540_NUM_REGULATOR_REGISTERS;
> match = ab9540_regulator_match;
> - match_size = ARRAY_SIZE(ab9540_regulator_match)
> + match_size = ARRAY_SIZE(ab9540_regulator_match);
> } else if (is_ab8505(ab8500)) {
> regulator_info = ab8505_regulator_info;
> regulator_info_size = ARRAY_SIZE(ab8505_regulator_info);
> @@ -3032,7 +3032,7 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
> reg_init = ab8500_reg_init;
> reg_init_size = AB8500_NUM_REGULATOR_REGISTERS;
> match = ab8500_regulator_match;
> - match_size = ARRAY_SIZE(ab8500_regulator_match)
> + match_size = ARRAY_SIZE(ab8500_regulator_match);
> }
>
> if (np) {

We already satisfy this requirement in:

"regulator: ab8500: Use a struct to select the good regulator
configuration"

... which is queued.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/