Re: [PATCH v3.7+] HID: magicmouse: fix race between input_register()and probe()

[Benjamin Tissoires]

On 04/04/2013 09:51 AM, Jiri Kosina wrote:
> On Tue, 2 Apr 2013, Benjamin Tissoires wrote:
> 
>> Since kernel 3.7, it appears that the input registration occured before
>> the end of magicmouse_setup_input(). This is shown by receiving a lot of
>> "EV_SYN SYN_REPORT 1" instead of normal "EV_SYN SYN_REPORT 0".
>> This value means that the output buffer is full, and the user space
>> is loosing events.
>>
>> Using .input_configured guarantees that the race is not occuring, and that
>> the call of "input_set_events_per_packet(input, 60)" is taken into account
>> by input_register().
>>
>> Fixes:
>> https://bugzilla.redhat.com/show_bug.cgi?id=908604
>>
>> Reported-and-Tested-By: Clarke Wixon <cwixon@xxxxxxx>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
>> ---
>>
>> Hi Jiri,
>>
>> this one can goes to stable (so 3.8) as well.
> 
> Applied, and will push for 3.9 still.

Ok, thanks Jiri.

Cheers,
Benjamin

> 
> Thanks.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/