Re: [RFC] Add implicit barriers to irqsave/restore class offunctions

[Peter Zijlstra]

On Wed, 2013-04-03 at 15:10 +0200, Christian Ruppert wrote:
> This patch adds implicit memory barriers to irqsave/restore functions
> of
> the ARC architecture port in line with what is done in other
> architectures.

> diff --git a/arch/arc/include/asm/irqflags.h
> b/arch/arc/include/asm/irqflags.h
> index ccd8480..c8147d1 100644
> --- a/arch/arc/include/asm/irqflags.h
> +++ b/arch/arc/include/asm/irqflags.h
> @@ -39,7 +39,7 @@ static inline long arch_local_irq_save(void)
>         "       flag.nz %0              \n"
>         : "=r"(temp), "=r"(flags)
>         : "n"((STATUS_E1_MASK | STATUS_E2_MASK))
> -       : "cc");
> +       : "memory", "cc");

That's not a memory barrier, that a memory clobber, aka a compiler
barrier.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/