Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addrin cpio files info array

[Tejun Heo]

On Thu, Apr 04, 2013 at 11:27:42AM -0700, Tejun Heo wrote:
> > +		/*
> > +		 * have to use unsigned long, otherwise 32bit spit warning
> > +		 * and it is ok to unsigned long, as bootloader would not
> > +		 * load initrd above 4G for 32bit kernel.
> > +		 */
> > +		unsigned long addr = (unsigned long)acpi_initrd_files[no].data;
> 
> I can't say I like this.  It's stuffing phys_addr_t into void *.  It
> might work okay but the code is a bit misleading / confusing.  "void
> *" shouldn't contain a physical address.  Maybe the alternatives are
> uglier, I don't know.  If you can think of a reasonable way to not do
> this, it would be great.

Also the comment contradicts with what you wrote in the next patch.

  Boot loader could load initrd above max_low_pfn.

Hmmm?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/