Re: [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubledhid_get_drvdata

From: Jiri Kosina
Date: Thu Apr 04 2013 - 18:37:44 EST


On Thu, 4 Apr 2013, Jiri Slaby wrote:

> In pointer_press_speed_show, we do
> data_pointer = hid_get_drvdata(hdev);
> twice in a row. Remove one of those.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Jiri Kosina <jkosina@xxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx
> ---
> drivers/hid/hid-lenovo-tpkbd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hid/hid-lenovo-tpkbd.c b/drivers/hid/hid-lenovo-tpkbd.c
> index a0535fd..07837f5 100644
> --- a/drivers/hid/hid-lenovo-tpkbd.c
> +++ b/drivers/hid/hid-lenovo-tpkbd.c
> @@ -228,8 +228,6 @@ static ssize_t pointer_press_speed_show(struct device *dev,
> struct hid_device *hdev = container_of(dev, struct hid_device, dev);
> struct tpkbd_data_pointer *data_pointer = hid_get_drvdata(hdev);
>
> - data_pointer = hid_get_drvdata(hdev);
> -

Applied, thanks.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/