Re: [patch v7 15/21] sched: pull all tasks from source group

[Alex Shi]

On 04/04/2013 01:59 PM, Namhyung Kim wrote:
>> > -		if (capacity && rq->nr_running == 1 && wl > env->imbalance)
>> > +		if (rq->nr_running == 0 ||
>> > +			(!(env->flags & LBF_POWER_BAL) && capacity &&
>> > +				rq->nr_running == 1 && wl > env->imbalance))
> Just out of curious.
> 
> In load_balance(), we only move normal tasks, right?
> 
> Then shouldn't it check rq->cfs.h_nr_running rather than rq->nr_running?

Yes, it seems so.
What's your opinion of this, Peter?

-- 
Thanks
    Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/