Re: [PATCH v4, part3 08/15] mm: fix some trivial typos in comments

From: Jiang Liu
Date: Sat Apr 06 2013 - 10:46:09 EST


On 04/06/2013 10:36 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 06-04-2013 17:55, Jiang Liu wrote:
>
>> Fix some trivial typos in comments.
>
>> Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx>
>> Cc: Wen Congyang <wency@xxxxxxxxxxxxxx>
>> Cc: Tang Chen <tangchen@xxxxxxxxxxxxxx>
>> Cc: Jiang Liu <jiang.liu@xxxxxxxxxx>
>> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx>
>> Cc: Mel Gorman <mgorman@xxxxxxx>
>> Cc: Minchan Kim <minchan@xxxxxxxxxx>
>> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>> Cc: linux-mm@xxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
> [...]
>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index 57decb2..a5b8fde 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -309,7 +309,7 @@ static int __meminit move_pfn_range_left(struct zone *z1, struct zone *z2,
>> /* can't move pfns which are higher than @z2 */
>> if (end_pfn > zone_end_pfn(z2))
>> goto out_fail;
>> - /* the move out part mast at the left most of @z2 */
>> + /* the move out part must at the left most of @z2 */
>
> Maybe "must be"?
Good catch!

>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 6bd697c..c3c3eda 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -2863,7 +2863,7 @@ EXPORT_SYMBOL(free_pages_exact);
>> * nr_free_zone_pages() counts the number of counts pages which are beyond the
>> * high watermark within all zones at or below a given zone index. For each
>> * zone, the number of pages is calculated as:
>> - * present_pages - high_pages
>> + * managed_pages - high_pages
>
> I'm not sure it's that trivial.
We just changes the comments to follow the code, so mark it as "trivial".

Regards!
Gerry

>
> WBR, Sergei
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/