Re: [RFC PATCH 2/3] perf: Add persistent event facilities

From: Robert Richter
Date: Sat Apr 06 2013 - 12:29:27 EST


On 03.04.13 19:27:12, Borislav Petkov wrote:
> > > + list_for_each_entry(desc, &per_cpu(pers_events, cpu), plist) {
> > > +
> > > + if (desc->attr->config != attr->config)
> > > + continue;
> >
> > Umm, the attr->config is not sufficient as a selector since it must be
> > unique which is not granted (of course it works for one event only).
>
> Right, so the tracepoints are enumerated by tracing code at boot
> time. But not the hw events, for example. How can we select events
> unambiguously?

As we discussed personally, in a first version we should allow only
the tracepoint pmu to be used for persistent events. The config value
is then unique and the above works.

-Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/