Re: [PATCH v2 0/3] Support memory hot-delete to boot memory
From: Toshi Kani
Date: Mon Apr 08 2013 - 17:10:47 EST
On Mon, 2013-04-08 at 13:44 -0700, Andrew Morton wrote:
> On Mon, 8 Apr 2013 11:09:53 -0600 Toshi Kani <toshi.kani@xxxxxx> wrote:
> > Memory hot-delete to a memory range present at boot causes an
> > error message in __release_region(), such as:
> > Trying to free nonexistent resource <0000000070000000-0000000077ffffff>
> > Hot-delete operation still continues since __release_region() is
> > a void function, but the target memory range is not freed from
> > iomem_resource as the result. This also leads a failure in a
> > subsequent hot-add operation to the same memory range since the
> > address range is still in-use in iomem_resource.
> > This problem happens because the granularity of memory resource ranges
> > may be different between boot and hot-delete.
> So we don't need this new code if CONFIG_MEMORY_HOTPLUG=n? If so, can
> we please arrange for it to not be present if the user doesn't need it?
Good point! Yes, since the new function is intended for memory
hot-delete and is only called from __remove_pages() in
mm/memory_hotplug.c, it should be added as #ifdef CONFIG_MEMORY_HOTPLUG
in PATCH 2/3.
I will make the change, and send an updated patch to PATCH 2/3.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/