Re: hangs on boot in 9984d7394618df9

From: Al Viro
Date: Mon Apr 08 2013 - 18:57:23 EST


On Mon, Apr 08, 2013 at 11:46:37PM +0100, Al Viro wrote:

> Very interesting... Just in case, could you try this on top of that
> branch and see if it triggers?
>
> diff --git a/fs/pipe.c b/fs/pipe.c
> index 8ce279b..b6cd51b 100644
> --- a/fs/pipe.c
> +++ b/fs/pipe.c
> @@ -1022,6 +1022,11 @@ static int fifo_open(struct inode *inode, struct file *filp)
> /* We can only do regular read/write on fifos */
> filp->f_mode &= (FMODE_READ | FMODE_WRITE);
>
> + if (inode->i_sb->s_magic == PIPEFS_MAGIC) {
> + WARN_ON(filp->f_flags & O_NONBLOCK);
> + filp->f_flags &= ~O_NONBLOCK;
> + }

*d'oh*

OK, I'm an idiot. I see what's going on now... Give me a few and I'll push
a fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/