Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings
From: Joe Perches
Date: Mon Apr 08 2013 - 23:45:53 EST
On Tue, 2013-04-09 at 09:06 +0530, Sachin Kamat wrote:
> On 9 April 2013 08:39, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
> >> On 13 March 2013 14:42, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> >> > Fixes the following warnings:
> >> > WARNING: line over 80 characters
> >> > WARNING: Prefer pr_warn(... to pr_warning(...
> >> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> > 
> >> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
> > 
> >> > - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
> >> > + pr_warn("%s: irq desc alloc failed. "
> >> > + "Continuing with %d as linux irq base\n",
> >> > + __func__, irq_base);
> > Please don't split formats.
> > See Documentation/CodingStyle Chapter 2
> > pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n",
> > __func__, irq_base);
> Thanks for pointing out. If I didn't split it, it would have exceeded
> the 80 column limit.
> Since there were 2 different sentences, I thought
> grepping should not be a problem if split at sentence boundaries.
I think it's OK to split at \n but not necessarily
at a sentence boundary/period.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/