Re: [PATCH 13/12] memcg: don't need memcg->memcg_name
From: Tejun Heo
Date: Mon Apr 08 2013 - 23:59:17 EST
On Tue, Apr 09, 2013 at 11:18:21AM +0800, Li Zefan wrote:
> >> - if (memcg->memcg_name)
> >> - seq_printf(m, "%s:\n", memcg->memcg_name);
> >> + ret = cgroup_path(memcg->css.cgroup, memcg_name, PAGE_SIZE);
> >> + if (!ret)
> >> + seq_printf(m, "%s:\n", memcg_name);
> >> else
> >> seq_printf(m, "%p (name lost):\n", memcg);
> > I'm sorry for dawm question ...when this error happens ?
> > We may get ENAMETOOLONG even with PAGE_SIZE(>=4096bytes) buffer ?
> It does no harm to check the return value, and we don't have to
> worry about if cgroup_path() will be changed to return some other
> errno like ENOMEM in the future.
Maybe change the function to return the length of the path regardless
of the specified buffer length? ie. as in snprintf()?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/