Re: [PATCH] checkpatch: Check block comments outside of net
From: Matthijs Kooijman
Date: Tue Apr 09 2013 - 07:37:12 EST
On Tue, Apr 09, 2013 at 04:32:54AM -0700, Joe Perches wrote:
> > Note that this patch rejects /** comments, since those are not mentioned
> > in Codingstyle. They are used in practice though (around 1000 occurences
> > in kernel/ alone), so perhaps they should be allowed and documented?
> Those are kernel-doc comments and must be allowed.
> see Documentation/kernel-doc-nano-HOWTO.txt
I just realized that as well, I'll send an updated patch.
> > Also, the new check only fires when the previous line is empty, just
> > like the start of block comment check for net/. However, I couldn't find
> > any documentation on why this restriction is needed?
> I'm not that concerned about block comment style.
> Maybe others are.
I'm not entirely sure if this is a answer to my question? Or are you
saying you don't really care about this and thus don't know the answer?
> Please make it a --strict (CHK) only test for now.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/