RE: [PATCH v9 1/2] ARM: davinci: dm365: add support for v4l2 videodisplay

From: Greg Veintimilla
Date: Tue Apr 09 2013 - 19:58:14 EST

Please remove me from this list. Thanks

-----Original Message-----
From: [] On Behalf Of Sekhar Nori
Sent: Tuesday, April 09, 2013 5:48 AM
To: Prabhakar lad
Subject: Re: [PATCH v9 1/2] ARM: davinci: dm365: add support for v4l2 video display

On 4/8/2013 2:47 PM, Prabhakar lad wrote:
> From: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Create platform devices for various video modules like venc,osd, vpbe
> and v4l2 driver for dm365.
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Acked-by: Sekhar Nori <nsekhar@xxxxxx>
> ---

> diff --git a/arch/arm/mach-davinci/davinci.h
> b/arch/arm/mach-davinci/davinci.h index 12d544b..a9de512 100644
> --- a/arch/arm/mach-davinci/davinci.h
> +++ b/arch/arm/mach-davinci/davinci.h
> @@ -36,8 +36,13 @@
> #include <media/davinci/vpbe_osd.h>
> #define DAVINCI_SYSTEM_MODULE_BASE 0x01c40000
> +#define SYSMOD_VDAC_CONFIG 0x2c
> #define SYSMOD_VIDCLKCTL 0x38
> #define SYSMOD_VPSS_CLKCTL 0x44
> +

Prabhakar, I noticed it only after I applied these patches, but these bit definitions in between list of register offsets is distracting. Can you please move them down after the register offsets when you send the pull request? You can add a comment /* VPSS CLKCTL bit definitions */ before you start the bit definitions.

> #define SYSMOD_VDD3P3VPWDN 0x48
> #define SYSMOD_VSCLKDIS 0x6c
> #define SYSMOD_PUPDCTL1 0x7c

Davinci-linux-open-source mailing list
IMPORTANT NOTICE: This communication, including any attachments, is the property of FreeWave Technologies, Inc. and may contain proprietary, confidential, or privileged information. Unauthorized use or disclosure of this communication is strictly prohibited and may be unlawful. Information contained herein may be subject to a Proprietary Information / Non-Disclosure Agreement and shall be maintained in confidence and not disclosed to third parties without the written consent of FreeWave Technologies, Inc. If you have received this communication in error, please immediately notify the sender and destroy all copies of the communication and any attachments.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at