Re: [PATCH] mm: pageattr: convert noop to functional fix

From: Borislav Petkov
Date: Wed Apr 10 2013 - 09:33:54 EST


On Wed, Apr 10, 2013 at 03:28:25PM +0200, Andrea Arcangeli wrote:
> Commit a8aed3e0752b4beb2e37cbed6df69faae88268da introduced some valid
> fix but one location that didn't trigger the bug that lead to finding
> those (small) problems, wasn't updated using the right variable.
>
> The wrong variable was also initialized for no good reason, that may
> have been the source of the confusion. Remove the noop initialization
> accordingly.
>
> Commit a8aed3e0752b4beb2e37cbed6df69faae88268da also erroneously
> removed one canon_pgprot pass meant to clear pmd bitflags not
> supported in hardware by older CPUs, that automatically gets corrected
> by this patch too by applying it to the right variable in the new
> location.
>
> Reported-by: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
> Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>

Acked-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/