Re: [PATCH] checkpatch: Warn on comparisons to true and false
From: Joe Perches
Date: Wed Apr 10 2013 - 21:07:23 EST
On Wed, 2013-04-10 at 15:57 -0700, Andrew Morton wrote:
> On Tue, 09 Apr 2013 20:17:14 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Comparisons of A to true and false are better written
> > as A and !A.
> > Bleat a message on use.
> hm. I'm counting around 1,100 instances of "== true" and "== false".
And about all of them in are staging, where I think they
really should be fixed.
$ find . -maxdepth 2 -type d \
while read file ; do \
echo "$(git grep -E '(==|\!=)\s*(true|false)' $file | wc -l) $file"; \
done | sort -rn | head -10
> That's a lot of people to shout at.
> Is it really worthwhile?
I think so.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/