Re: [PATCH] kernel: auditfilter: looping issue, memory leak if has2 or more AUDIT_FILTERKEYs

From: Chen Gang
Date: Wed Apr 10 2013 - 23:44:10 EST

On 2013å04æ11æ 05:32, Eric Paris wrote:
> ----- Original Message -----
>> >
>> > also for function audit_list:
>> > when call audit_make_reply fails (will return NULL).
>> > we need free all its related variables instead of only kfree rull.
>> > (such as call autit_free_rule)
>> >
>> > please help check, thanks.
> audit_free_rule() takes a struct audit_entry, not an audit_rule.

yes. but maybe you misunderstand what I said (excuse me, my English is
not quite weill)
I said: "need we process the rule just like audit_free_rule has done ?"

> struct audit_rule does not have additional things which need to be freed...

oh, it is my fault:
(I did not notice: rule is struct audit_rule, not struct audit_krule).



Chen Gang

Asianux Corporation
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at