Re: [PATCH] net: mv643xx_eth: remove deprecated inet_lro support

[Sebastian Hesselbarth]

On 04/11/2013 09:46 PM, Eric Dumazet wrote:
> On Thu, 2013-04-11 at 21:11 +0200, Sebastian Hesselbarth wrote:
> > With recent support for GRO, there is no need to keep both LRO and
> > GRO. This patch therefore removes the deprecated inet_lro support
> > from mv643xx_eth. This is work is based on an experimental patch
> > provided by Eric Dumazet and Willy Tarreau.
> >
> > Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@xxxxxxxxx>
> > Based-on-patch-by: Eric Dumazet<eric.dumazet@xxxxxxxxx>
> > Based-on-patch-by: Willy Tarreau<w@xxxxxx>
> > ---
> > Note: This patch is based upon recent cleanup patches and GRO support
> > patch for mv643xx_eth.
> >
> > Cc: "David S. Miller"<davem@xxxxxxxxxxxxx>
> > Cc: Lennert Buytenhek<buytenh@xxxxxxxxxxxxxx>
> > Cc: Andrew Lunn<andrew@xxxxxxx>
> > Cc: Jason Cooper<jason@xxxxxxxxxxxxxx>
> > Cc: Florian Fainelli<florian@xxxxxxxxxxx>
> > Cc: Benjamin Herrenschmidt<benh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Paul Mackerras<paulus@xxxxxxxxx>
> > Cc: Dale Farnsworth<dale@xxxxxxxxxxxxxx>
> > Cc: Ben Hutchings<bhutchings@xxxxxxxxxxxxxx>
> > Cc: Soeren Moch<smoch@xxxxxx>
> > Cc: Eric Dumazet<eric.dumazet@xxxxxxxxx>
> > Cc: Willy Tarreau<w@xxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > ---
> >   drivers/net/ethernet/marvell/mv643xx_eth.c |   97 +---------------------------
> >   1 file changed, 3 insertions(+), 94 deletions(-)
>
> Seems fine to me, but you also could remove "select INET_LRO"
> from drivers/net/ethernet/marvell/Kconfig

Ok, I will wait for tomorrow to see if there are more objections and
respin a v2.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/