Re: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]

From: Ian Abbott
Date: Fri Apr 12 2013 - 06:56:40 EST

On 2013-04-11 20:05, Greg Kroah-Hartman wrote:
On Thu, Apr 11, 2013 at 04:15:52PM +0100, David Howells wrote:
Ian Abbott <abbotti@xxxxxxxxx> wrote:

Don't use create_proc_read_entry() as that is deprecated, but rather use
proc_create_data() and seq_file instead.

It seems to work okay and is simpler than I thought it would be! You changed
the mode of the file to 0644 for some reason though. Please change it back to
0444 or S_IFREG | S_IRUGO. Thanks.

Ah... cut'n'paste error. Sorry about that.

I can fix that up by hand when I apply it, no worries.

You may need to sync with linux-next first, particularly commit e784788ddb7000dbea8bd2986a3f83c4d77f96ff by Al Viro "get rid of a bunch of open-coded create_proc_read_entry()".

-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at