Re: [PATCH v2] net: mv643xx_eth: remove deprecated inet_lro support

From: David Miller
Date: Fri Apr 12 2013 - 15:05:55 EST

From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Fri, 12 Apr 2013 05:55:39 -0700

> On Fri, 2013-04-12 at 11:20 +0200, Sebastian Hesselbarth wrote:
>> With recent support for GRO, there is no need to keep both LRO and
>> GRO. This patch therefore removes the deprecated inet_lro support
>> from mv643xx_eth. This is work is based on an experimental patch
>> provided by Eric Dumazet and Willy Tarreau.
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
>> Based-on-patch-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
>> Based-on-patch-by: Willy Tarreau <w@xxxxxx>
>> ---
>> Changes from v1:
>> - also remove INET_LRO from Kconfig (Reported by Eric Dumazet)
> Thanks for finishing this patch
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Applied, but this driver is full of skeletons:

drivers/net/ethernet/marvell/mv643xx_eth.c: In function ʽrxq_refillʼ:
drivers/net/ethernet/marvell/mv643xx_eth.c:618:19: error: invalid operands to binary - (have ʽsk_buff_data_tʼ and ʽunsigned char *ʼ)

which is:

size = skb->end - skb->data;

that is absolutely not a legal computation.

It happens to be in the only configuration for which this driver
can be enabled in Kconfig but that is no excuse for it :-)
ʼιμΉ»?&ή~Ί&Ά¬?+-±ιέΆ??w??Λ?±Κβmιb?μdzΉή?)ν?ζθw*jg¬±¨Ά????έʼj/?κδzΉή??ΰ2?ή?¨θ­Ϊ&ʼ)ίʽ«aΆΪώψ?G«?ιh?ζj:+v?¨?wθ?Ω?>W?±κήiΫaxPjΨmΆ??Γ -»+?ωd?_